Opened 4 years ago

Last modified 4 years ago

#43 confirmed enhancement

Better movement human player code

Reported by: bigjj13 Owned by:
Priority: normal Milestone:
Component: Games Version: svn-head
Keywords: HumanPlayer.cpp Cc:
Platform:

Description (last modified by Carsten)

This is the final changed HumanPlayer.cpp file

Attachments (5)

HumanPlayer.cpp.patch (7.4 KB) - added by bigjj13 4 years ago.
HumanPlayer.hpp.patch (762 bytes) - added by bigjj13 4 years ago.
footstepsrun.wav (105.4 KB) - added by bigjj13 4 years ago.
footstepswalk.wav (108.6 KB) - added by bigjj13 4 years ago.
Ambient.caud.patch (483 bytes) - added by bigjj13 4 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 follow-up: Changed 4 years ago by Stephen

Does the HumanPlayer code in the Deathmatch have a crouch function yet? That would be a good improvement too.

comment:2 in reply to: ↑ 1 Changed 4 years ago by Carsten

Replying to Stephen:

Does the HumanPlayer code in the Deathmatch have a crouch function yet?

Sorry, no, not yet.

That would be a good improvement too.

Agreed! XD

comment:3 in reply to: ↑ description Changed 4 years ago by Carsten

  • Description modified (diff)
  • Status changed from new to infoneeded
  • Type changed from optimization to enhancement

Replying to bigjj13:

This is the final changed HumanPlayer.cpp file

Thanks for your patch, but could you please explain the meaning and purpose of the local variable Runspon?

For example, it's difficult to see (and explain) why this piece of code is like it is:

if (Runspon!=0)
{
    if (Runspon!=2)
    {
        WishVelocity=scale(WishVelocity, 4.0);   // Run
        if (Runspon==4) Runspon=4;
        else Runspon=3;
    }
}

if (Runspon==4) Runspon=4; makes sense only for the else-clause...

comment:4 Changed 4 years ago by bigjj13

  • Status changed from infoneeded to confirmed

Hi,

Carste Im going to change that

Stephen Good Idea. In work

Sincerely

Changed 4 years ago by bigjj13

Changed 4 years ago by bigjj13

Changed 4 years ago by bigjj13

Changed 4 years ago by bigjj13

comment:5 Changed 4 years ago by Carsten

Thank you very much!

A few questions though:

  • Do I assume right that Humanplayer.patch is obsolete?
  • (Are you aware that a patch can cover multiple files?)
  • It would be ideal if you could split the ticket in one that addresses the player movement (in a single patch) and another one that adds sounds (also in a single patch except for the wav files). This is the least important item in this list though; you may see Make atomic patches for more details.
  • Please let me know about any obsolete or stale attachments that can or should be deleted.
  • Ambient.caud mentions otherwise unused sound shader Sgcalarm, please review!
  • Please see my notes in comment 3 above.

comment:6 Changed 4 years ago by bigjj13

Hi,

this new things will only work with my better human movement.

Kan you please delete Humanplayer.patch? It has no use anymore.

"Ambient.caud mentions otherwise unused sound shader Sgcalarm, please review!" Thanks ill check that.

Ill add some comments later 3-4 days.

Sincerely

Admin(SG-O)

Changed 4 years ago by bigjj13

Note: See TracTickets for help on using tickets.