Ticket #6 (closed defect: fixed)

Opened 7 months ago

Last modified 7 months ago

[cppcheck] found a redundant ')' in macro declaration

Reported by: orbitcowboy Owned by: Carsten
Priority: normal Milestone:
Component: ExtLibs Version: svn-head
Keywords: libpng Cc:
Platform:

Description

during a check of the current svn head from cafu, the static code analysis tool cppcheck ( http://sourceforge.net/projects/cppcheck/) found a regression.

Please refer the attached patch, it fixes the issue.

Best regards

Ettl Martin

Attachments

cppcheck_regression_fix.patch Download (0.5 KB) - added by orbitcowboy 7 months ago.
fix

Change History

Changed 7 months ago by orbitcowboy

fix

Changed 7 months ago by Carsten

  • keywords libpng added
  • owner set to Carsten
  • status changed from new to confirmed
  • component changed from other to ExtLibs

Thank you very much for the check and patch!

This is actually a problem in libpng, whose test code we don't use.
I'll check tomorrow morning if a later release of libpng fixes the issue and then see if we apply the patch, or upgrade to a (patched) version of libpng, so that in either case the result is a fixed libpng.

Changed 7 months ago by Carsten

  • status changed from confirmed to closed
  • resolution set to fixed

(In [45]) Applied patch by Ettl Martin for removing redundant ')' in macro declaration.
Closes #6.

Note: See TracTickets for help on using tickets.